Skip to content

feat: #8 Proguard/R8#14

Merged
TheRealAgentK merged 8 commits intomainfrom
8-r8proguard
Jan 27, 2025
Merged

feat: #8 Proguard/R8#14
TheRealAgentK merged 8 commits intomainfrom
8-r8proguard

Conversation

@TheRealAgentK
Copy link
Contributor

@TheRealAgentK TheRealAgentK commented Jan 26, 2025

feat: #8 - Proguard/R8

Description 📝

  • Purpose: Adds support for uploading Android Proguard and R8 mapping files via raygun-cli
  • Approach: New proguard command

Type of change

  • New feature (non-breaking change which adds functionality)

Updates

👉 Created new flow for a proguard command in main
👉 Created command, Proguard class and API handlers
👉 Added documentation in README

Test plan 🧪

Tested manually with various setting of arguments

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@TheRealAgentK TheRealAgentK requested review from a team, CmdrKeen, miquelbeltran, nikz and sumitramanga and removed request for a team January 26, 2025 05:08
@TheRealAgentK
Copy link
Contributor Author

TheRealAgentK commented Jan 26, 2025

@miquelbeltran See: #5 (comment)

I think before the next release, the overarching config setup with app-id and token needs to be looked at.

Doesn't stop this from being merged, I think - but fixing the problem in my comment will lead to all commands being able to be simplified re required arguments, I think.

@miquelbeltran
Copy link
Contributor

miquelbeltran commented Jan 26, 2025 •
edited
Loading

@TheRealAgentK I've created a refactor of the config props that will probably help as well with this one, it already removes the need to pass the app-id in the deployment command, and can be used here so token is not necessary.

See #15

You can also use the new ConfigProp to parse external-access-token from env-vars if you want.

@TheRealAgentK
Copy link
Contributor Author

TheRealAgentK commented Jan 27, 2025

@miquelbeltran I merged in your config/env changes from #15 🦖 , and then aligned the code / docs in there to them. I think it's ready now.

@TheRealAgentK TheRealAgentK merged commit d3a9cc5 into main Jan 27, 2025
5 checks passed
@sumitramanga sumitramanga deleted the 8-r8proguard branch May 2, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miquelbeltran miquelbeltran miquelbeltran approved these changes

@nikz nikz Awaiting requested review from nikz nikz was automatically assigned from MindscapeHQ/kai-miquel-and-friends

@sumitramanga sumitramanga Awaiting requested review from sumitramanga sumitramanga was automatically assigned from MindscapeHQ/kai-miquel-and-friends

@CmdrKeen CmdrKeen Awaiting requested review from CmdrKeen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheRealAgentK @miquelbeltran